Adding finetuning samples and tests #43749
Open
+2,379
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayesh-tanna
requested review from
dargilco,
glharper,
howieleung,
nick863 and
trangevi
as code owners
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
dargilco
requested changes
Nov 6, 2025
sdk/ai/azure-ai-projects/samples/finetuning/sample_finetuning_dpo_job.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/finetuning/sample_finetuning_oss_models_supervised_job.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/finetuning/sample_finetuning_oss_models_supervised_job.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/finetuning/sample_finetuning_supervised_job.py
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/finetuning/sample_finetuning_dpo_job.py
Show resolved
Hide resolved
Member
|
Please update https://microsoft-my.sharepoint.com/:x:/p/dcohen/IQBab1pCpJAkQ7e-XPUpXiOuAY_le6sw3t0VvKnsNu6YMjQ?e=YHam4v&nav=MTVfezAwMDAwMDAwLTAwMDEtMDAwMC0wMDAwLTAwMDAwMDAwMDAwMH0 when you are done to reflect the status after your PR completes. Thanks! |
dargilco
approved these changes
Nov 7, 2025
| azure_ai_projects_azure_subscription_id="00000000-0000-0000-0000-000000000000", | ||
| azure_ai_projects_azure_resource_group="sanitized-resource-group", | ||
| azure_ai_projects_azure_aoai_account="sanitized-aoai-account", | ||
| ) |
Member
There was a problem hiding this comment.
names like "azure_ai_projects_azure_subscription_id" will not work... did it work for you? From my experience it has to start with "azure_ai_projects_tests", the 2nd value passed in to functools.partial(.
It's okay to have two sets of env variables in .env.template file. One targeting test and the other samples. We can discuss later if we want to simplify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines